Fixup of initial jt-264-basics merge PR #282 #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrpav
requested changes
Aug 4, 2023
| @@ -267,6 +270,74 @@ protected Object copyInternal(ObjectLocator locator, Cloneable object) { | |||
| } | |||
| } | |||
| } | |||
| protected Object copyInternalJdk11(ObjectLocator locator, Cloneable object) { | |||
There was a problem hiding this comment.
This method has a lot of copy+paste from the other copyInternal. Perhaps we can just add an argument to adjust behavior to the original method?
There was a problem hiding this comment.
I didn't want to change existing behaviour for jdk8 / jdk11 which makes it works well.
The exception is only thrown with jdk17 since jdk16 has locked more aggressively the internal jdk classes.
This can be the default impl with jakarta-jaxb4 since baseline will be jdk11 (jaxb4 requires jdk11)
basics/tools/src/test/java/org/jvnet/jaxb2_commons/reflection/util/test/URIInternalTest.java
Outdated
Show resolved
Hide resolved
laurentschoelens
force-pushed
the
jt-264-basics-fixup
branch
from
dc1e879
to
c7a1e67
Compare
mattrpav
requested changes
Aug 4, 2023
laurentschoelens
force-pushed
the
jt-264-basics-fixup
branch
from
c7a1e67
to
68121f2
Compare
laurentschoelens
force-pushed
the
jt-264-basics-fixup
branch
from
68121f2
to
44dcda4
Compare
Done, see org.jvnet.jaxb2_commons.lang.tests.DefaultCopyStrategyTest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing build issues of PR #282 : build is now successfull on jdk8/11/17 with maven profile
-P allRenaming all modules to JAXB Tools :: ...
Fixing build dependencies of samples / tests of jaxb-maven-plugin on jaxb2-basics
Also fixes highsource/jaxb2-basics#130
Also fixes build issue (reflection access disallowed for URI class) on jdk17 (creating new internal class)