Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new test project for issue 250 (fixed by 2.0.2) #289

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

laurentschoelens
Copy link
Collaborator

Issue #250 as been fixed with latest release (2.0.2)
Just adding a new test project for NR Tests to not break it again

<artifactId>jaxb-maven-plugin-tests</artifactId>
<version>2.0.4-SNAPSHOT</version>
</parent>
<name>JAXB Tools :: Maven Plugin :: Test [JAXB-TOOLS 250]</name>
Copy link
Collaborator

@mattrpav mattrpav Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about using the <description> tag to explain what the test does? I like naming the tests after the ticket number, but might be handy to have the basic gist right there without having to hit the link. obviously, for complex things, the ticket detail will have all the notes.

@mattrpav mattrpav self-assigned this Aug 8, 2023
@mattrpav mattrpav added this to the 2.0.4 milestone Aug 8, 2023
Copy link
Collaborator

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattrpav mattrpav merged commit 2719edb into highsource:master Aug 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants