Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#560] add configuration for artifact exclusions in final classpath (which default to exclude xercesImpl and xml-apis artifacts) #562

Merged
merged 1 commit into from
Nov 20, 2024
Merged

[#560] add configuration for artifact exclusions in final classpath (which default to exclude xercesImpl and xml-apis artifacts) #562

merged 1 commit into from
Nov 20, 2024

Conversation

laurentschoelens
Copy link
Collaborator

Fixes #560
This make xercesImpl and xml-apis doesnt come into final classpath of maven-plugin since they could conflict with other classes and fail generation

@laurentschoelens laurentschoelens added this to the 4.0.9 milestone Aug 28, 2024
@laurentschoelens laurentschoelens changed the title [#560] exclude xercesImpl and xml-apis artifacts [#560] add configuration for artifact exclusions in final classpath (which default to exclude xercesImpl and xml-apis artifacts) Aug 30, 2024
@laurentschoelens laurentschoelens added enhancement maven-plugin Issue concerns maven plugin labels Oct 11, 2024
mattrpav
mattrpav approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@mattrpav mattrpav left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- please add a section to the doc about the specific problem and the config snippet to exclude:

xerces:xercesImpl
xml-apis

Thanks!

@mattrpav mattrpav merged commit 5903cd4 into highsource:master Nov 20, 2024
3 checks passed
@mattrpav mattrpav deleted the jt-560 branch November 20, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattrpav mattrpav mattrpav approved these changes

Assignees

@mattrpav mattrpav

Labels
enhancement maven-plugin Issue concerns maven plugin
Projects
None yet
Milestone
4.0.9
Development

Successfully merging this pull request may close these issues.

Random org.apache.xerces.impl.dv.DVFactoryException with 2.0.13 and 2.0.14
2 participants
@laurentschoelens @mattrpav