always re-require the package that we need in the requireWithFailedDe…

…pendency function
hildjj · Feb 10, 2021 · a2185fa · a2185fa
1 parent 59f3295
commit a2185fa
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/test/cases.js b/test/cases.js
@@ -26,7 +26,7 @@ async function requireWithFailedDependency(source, dependency, fn) {
     }
   }
   delete require.cache[src]
-  await fn()
+  await fn(require(source))
   require.cache[src] = old_src
   require.cache[dep] = old_dep
 }

diff --git a/test/constants.ava.js b/test/constants.ava.js
@@ -5,8 +5,7 @@ const cases = require('./cases')
 
 test('create', async t => {
   await cases.requireWithFailedDependency(
-    '../lib/constants', 'bignumber.js', () => {
-      const cnst = require('../lib/constants')
+    '../lib/constants', 'bignumber.js', (cnst) => {
       t.falsy(cnst.BigNumber)
       t.falsy(cnst.BN)
     })

diff --git a/test/utils.ava.js b/test/utils.ava.js
@@ -113,8 +113,7 @@ test('cborValueToString', t => {
 })
 
 test('web util', async t => {
-  cases.requireWithFailedDependency('../lib/utils', 'util', () => {
-    const utils = require('../lib/utils')
+  cases.requireWithFailedDependency('../lib/utils', 'util', utils => {
     t.falsy(utils.inspect)
   })
 })