Updated to support HipChat Server and API V2 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d90ec62.
Fixed an indentation issue, darn VIM!
Fixed another indent issue, darn vim..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just installed HipChat server tonight and was testing the Redmine plugin with no luck. Decided to dig into the code and see if I could get it working. Not so sure why room_id wasn't showing up, so I just changed all the references to room_name. (It had a few: room, room_id, room_name).
Changed the API request to support the latest API as of Today (Jan 7th 2015).
Added an option for the HipChat server URL.
Works now!