4850 onboard once #4907
Merged
4850 onboard once #4907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One more thing. I noticed that this problem (strangely) didn't come up in my testing of the changes on this PR so I didn't make any further tweaks to LocationStore. I do still think that we should refactor LocationStore eventually (maybe split out background functionality that doesn't manipulate or depend on other MST state), but that probably warrants more discussion. |
|
LGTM but not merging because ...
... southerneer might re-roll it. |
bengtan
approved these changes
Mar 12, 2020
southerneer
force-pushed
the
4850-onboard-once
branch
from
9b4f08e to
ebdb26e
Compare
|
rebased and force pushed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sticking with the MST version of PermissionStore for this one. We can handle the conversion to vanilla mobx in a later PR for #4889. Same goes for maintaining the old persistence mechanism until we approach #4849 more holistically.
@aksonov if you're planning to have #4906 done your Thursday (and assuming you approve the changes in this PR), please hold off merging this one since it would cause some path conflicts. I'll make the necessary tweaks my Thursday morning before deploying to Staging.