Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for #4905 #4912

Merged
merged 3 commits into from
Mar 16, 2020
Merged

for #4905 #4912

merged 3 commits into from
Mar 16, 2020

Conversation

aksonov
Copy link
Contributor

@aksonov aksonov commented Mar 13, 2020

No description provided.

@southerneer
Copy link
Contributor

It seems like the test failure could be related to this change. @aksonov does this PR depend on a back-end change too?

@aksonov
Copy link
Contributor Author

aksonov commented Mar 13, 2020

@southerneer Yes, looks like it is exact problem I described before - 'nearby end' event is not received:

    await bob.setLocation(differentLocation)
    await waitFor(() => !friend!.sharesLocation, 'end sharing location')
    await waitFor(() => !bob.profile!.sharesLocation, 'end sharing location')

@southerneer
Copy link
Contributor

southerneer commented Mar 13, 2020

I codepushed this branch to StagingPavel and pinged Miranda to test. Phil is pushing back-end changes to Staging too.

@bengtan
Copy link
Contributor

bengtan commented Mar 16, 2020

I re-ran the CircleCI tests and it passed.

There was a server deployment an hour-or-so after the most recent failed test so it seems that fixed up the back-end.

LGTM.

@bengtan
Copy link
Contributor

bengtan commented Mar 16, 2020

Just discovered that QA has posted some feedback at #4905 so ... maybe this PR needs some more work?

@aksonov
Copy link
Contributor Author

aksonov commented Mar 16, 2020

Great, it is very good to know that tests are passed, I'm going to merge it. More work could be done in other PR

@aksonov aksonov merged commit 645a95b into master Mar 16, 2020
@aksonov aksonov deleted the 4905 branch March 16, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants