Modifications using numpy operations, CI #9

V-Rang · 2024-03-16T15:42:40Z

Modifications done using numpy operations and CI implemented for checking code in serial and parallel in numpy_debug_v2 branch.
CI tests for:

symmetric nature of Hessian
slope approximately one for FD Gradient and Hessian Check.
iNCG optimizer converges with "Norm of gradient less than tolerance".

uvilla

Thank you Venugopal,
This is good work. I left you a few minor comments before we can merge.

.github/workflows/CI_testing.yml

example/poisson_example.py

example/sfsi_toy_gaussian.py

example/testing_folder/test_script.py

hippylibX/modeling/modelVerify.py

hippylibX/test/testing_suite_file.py

uvilla

Very good! Just a few minor comments/fixes.

example/sfsi_toy_gaussian.py

hippylibX/algorithms/linSolvers.py

hippylibX/modeling/prior.py

uvilla

Few more comments

example/sfsi_toy_gaussian.py

hippylibX/modeling/PDEProblem.py

uvilla

A few more improvements are needed

hippylibX/modeling/Regularization.py

hippylibX/modeling/prior.py

uvilla

The PR looks good to me

V-Rang added 29 commits March 13, 2024 15:02

trying to implement auto testing

3e6c03e

trying to implement auto testing

2f7b624

trying to implement auto testing

f90e745

trying to implement auto testing

75e92b2

implement CI

08b668a

implement CI

269dcb5

implement CI

65bd967

implement CI

3faa6eb

implement CI

e1228b6

CI implement

09d1aa0

testing script added

ab3aaf0

implement CI fix

4f7f694

mpi hang not observed if plt.show() not last line

3f556ba

plt.show() not hanging with multiproc

21d5b36

possible memory issue needs to be fixed

8e0e656

testing suite comments removed

51ae577

possible memory issue

dee84e5

investigatingmemory usage

20bec60

updated testing suite file

9906551

unit tests update v_1

d773a21

updated Dockerfile to test memory usage

2da1208

updated testing file

4882861

CI attempt

6062ee5

removed mem_prof import

48857d7

update test file

29c38f2

update CI from 4 proc to 2 proc

94ab33c

testing if CI fails

f80fc13

testing suite working as expected

cfc422a

clean up

086a453

uvilla requested changes Mar 16, 2024

View reviewed changes

V-Rang added 8 commits March 16, 2024 12:28

testing CI v_1

6660458

testing CI v_1

a6743bd

testing CI v_1

7637683

testing CI - expected to fail

dd564d7

checking CI after minor changes to return values from modelVerify

c5a8b82

changes to testing suite

0c5567e

removed testing folder from example folder

c9ea067

final change _v1

894a510

uvilla requested changes Mar 18, 2024

View reviewed changes

V-Rang added 2 commits March 18, 2024 10:21

merged changes

a3ba6ba

removed files

00fb8b2

uvilla requested changes Mar 18, 2024

View reviewed changes

example/sfsi_toy_gaussian.py Outdated Show resolved Hide resolved

hippylibX/modeling/PDEProblem.py Outdated Show resolved Hide resolved

hippylibX/modeling/PDEProblem.py Show resolved Hide resolved

hippylibX/modeling/PDEProblem.py Show resolved Hide resolved

V-Rang added 3 commits March 18, 2024 13:04

minor fixes, MPI hang for multiproc pact with destructor in PDEProblem

8cacc43

MPI lag fixed

1c390ab

removing commented code

551bbbb

uvilla requested changes Mar 19, 2024

View reviewed changes

hippylibX/modeling/Regularization.py Show resolved Hide resolved

hippylibX/modeling/prior.py Show resolved Hide resolved

hippylibX/modeling/prior.py Show resolved Hide resolved

V-Rang and others added 9 commits March 19, 2024 09:12

prior del method, jacobi pc

776e6e8

need to fix Regularization.py

b76c9ce

Update Regularization.py

7a50535

Update prior.py

5ffc3f8

Update model.py

f83d5d4

Update prior.py

dc78353

Update Regularization.py

9a0e8c2

regularization prior example added

c56ec63

clean up

bf55be1

uvilla approved these changes Mar 19, 2024

View reviewed changes

V-Rang merged commit bf55be1 into main Mar 19, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modifications using numpy operations, CI #9

Modifications using numpy operations, CI #9

V-Rang commented Mar 16, 2024

uvilla left a comment

uvilla left a comment

uvilla left a comment

uvilla left a comment

uvilla left a comment

Modifications using numpy operations, CI #9

Modifications using numpy operations, CI #9

Conversation

V-Rang commented Mar 16, 2024

uvilla left a comment

Choose a reason for hiding this comment

uvilla left a comment

Choose a reason for hiding this comment

uvilla left a comment

Choose a reason for hiding this comment

uvilla left a comment

Choose a reason for hiding this comment

uvilla left a comment

Choose a reason for hiding this comment