Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nl-nl.json #10

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

314159265359879
Copy link

Please have a look at this update. I have used the en-us.json to make the changes.
Pay extra attention to the translations at web_bridge part, I am not sure I have translated the jargon correctly and I do not have access to dutch versions of Brave/Firefox for the exact menu items, I left those in English.

@314159265359879 314159265359879 mentioned this pull request Jul 4, 2021
3 tasks
Copy link
Contributor

@MarvinJanssen MarvinJanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! But JSON files cannot have comments. Take a look https://github.com/hirosystems/btc-us-website/pull/10/files. We can likely merge it once the comments are removed.

"manage": "Mijn domeinen",
"manage": "Beheer", //or "Mijn Domain" (singular)
"success": "Aankoop succesvol",
"web_bridge": "Web Bridge", //soortnaam, kan ook zo?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks, I have taken those out. It should be better now.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants