Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove obsolete nft_custody_unanchored table #2190

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

rafaelcr
Copy link
Collaborator

@rafaelcr rafaelcr commented Dec 20, 2024

Drops old table and ignores unanchored param for /nft/holdings.

Fixes #1843

Copy link

github-actions bot commented Dec 20, 2024

Vercel deployment URL: https://stacks-blockchain-mcb103jd6-hirosystems.vercel.app 🚀

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@rafaelcr rafaelcr requested a review from zone117x December 20, 2024 19:44
@rafaelcr rafaelcr marked this pull request as ready for review December 20, 2024 19:44
Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rafaelcr rafaelcr merged commit a5d2a8b into develop Dec 20, 2024
27 checks passed
@rafaelcr rafaelcr deleted the chore/drop-nft-custody-unanchored branch December 20, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

v1/tokens/nft/holdings doesn't return all NFTs
2 participants