BTVN8: added role to user.model, api login and api register, library bcrypt … #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caotrungduc03
changed the title
hung279
reviewed
May 20, 2023
src/controllers/auth.controller.js
Outdated
| throw err; | ||
| } | ||
|
|
||
| const token = await jwt.sign( |
There was a problem hiding this comment.
method sign này nó k trả về promise đâu nên mình k cần await nhé
src/controllers/auth.controller.js
Outdated
Comment on lines
44
to
53
| const { | ||
| avatar, | ||
| fullName, | ||
| dateOfBirth, | ||
| password, | ||
| studentCode, | ||
| className, | ||
| schoolYear, | ||
| clubYear | ||
| } = req.body; |
There was a problem hiding this comment.
avatar anh nghĩ k nên để trong phần đăng ký nhé. Đăng ký mình chỉ đưa những trường cần thiết thôi
Comment on lines
+17
to
+23
| const user = await User.findById(userId); | ||
| if (!user) { | ||
| const err = new Error("User not found!"); | ||
| err.status = 404; | ||
| throw err; | ||
| } | ||
|
|
There was a problem hiding this comment.
em thêm cho anh nếu mà user tồn tại thì mình sẽ gán nó vào req để sử dụng ở các hàm sau.
Suggested change
| const user = await User.findById(userId); | |
| if (!user) { | |
| const err = new Error("User not found!"); | |
| err.status = 404; | |
| throw err; | |
| } | |
| const user = await User.findById(userId); | |
| if (!user) { | |
| const err = new Error("User not found!"); | |
| err.status = 404; | |
| throw err; | |
| } | |
| req.user = user; | |
Co-authored-by: Tan Hung(hoon) <[email protected]>
src/controllers/auth.controller.js
Outdated
Comment on lines
29
to
31
| { | ||
| expiresIn: '1h' | ||
| } |
There was a problem hiding this comment.
không hard code ở thời gian sống của token, đặt biến trong .env và sử dụng nhé
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E nộp btvn buổi 8 ạ