Skip to content

Commit

Permalink
Remove unneeded disabling of an unused callback
Browse files Browse the repository at this point in the history
  • Loading branch information
kronn committed Dec 17, 2024
1 parent 86f0b18 commit 2de86cc
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 12 deletions.
4 changes: 0 additions & 4 deletions app/models/group/root.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ class Admin < ::Role
self.permissions = [:layer_and_below_full, :admin]
self.two_factor_authentication_enforced = true

def skip_alumnus_callback
true
end

def alumnus_manager
@alumnus_manager ||= Jubla::Role::NullAlumnusManager.new
end
Expand Down
4 changes: 0 additions & 4 deletions app/models/nejb_role.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@

class NejbRole < Role
module AlumnusFreeRole
def skip_alumnus_callback
true
end

def alumnus_manager
@alumnus_manager ||= Jubla::Role::NullAlumnusManager.new
end
Expand Down
4 changes: 0 additions & 4 deletions spec/models/nejb_role_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@
expect(subject).to be_a Jubla::Role
end

it "disables the alumnus-callback" do
expect(subject.skip_alumnus_callback).to be_truthy
end

it "uses the NullAlumnusManager" do
expect(subject.alumnus_manager).to be_a Jubla::Role::NullAlumnusManager
end
Expand Down

0 comments on commit 2de86cc

Please sign in to comment.