Give long line a better name

hitobito · Dec 11, 2024 · 2f215ea · 2f215ea
1 parent d6889b8
commit 2f215ea
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/app/jobs/alumni_mail_job.rb b/app/jobs/alumni_mail_job.rb
@@ -12,7 +12,7 @@ def initialize(group_id, person_id)
   end
 
   def perform
-    return if person.roles.without_alumnus.roles_in_layer(person.id, group.layer_group_id).any?
+    return if no_more_active_roles?
 
     if group.is_a?(Group::Flock)
       AlumniMailer.new_member_flock(person).deliver_now
@@ -23,6 +23,10 @@ def perform
 
   private
 
+  def no_more_active_roles?
+    person.roles.without_alumnus.roles_in_layer(person.id, group.layer_group_id).any?
+  end
+
   def group
     @group ||= Group.find(@group_id)
   end