Communicate use clearer what we need here

After all, name might change, sti_name is specifically for this
hitobito · Dec 18, 2024 · 381bd99 · 381bd99
1 parent ac56e01
commit 381bd99
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/domain/jubla/role/alumnus_manager.rb b/app/domain/jubla/role/alumnus_manager.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-#  Copyright (c) 2021, Jungwacht Blauring Schweiz. This file is part of
+#  Copyright (c) 2021-2024, Jungwacht Blauring Schweiz. This file is part of
 #  hitobito_jubla and licensed under the Affero General Public License version 3
 #  or later. See the COPYING file at the top-level directory or at
 #  https://github.com/hitobito/hitobito_jubla.
@@ -55,7 +55,7 @@ def destroy_alumnus_role
       person
         .roles
         .joins(:group)
-        .where(group: group, type: group.alumnus_class.name)
+        .where(group: group, type: group.alumnus_class.sti_name)
         .destroy_all
     end
 

diff --git a/app/domain/jubla/role/light_alumnus_manager.rb b/app/domain/jubla/role/light_alumnus_manager.rb
@@ -39,7 +39,7 @@ def destroy_alumnus_role
       person
         .roles
         .joins(:group)
-        .where(group: group, type: group.alumnus_class.name)
+        .where(group: group, type: group.alumnus_class.sti_name)
         .destroy_all
     end