Require person_add_requests on all groups (#106)

app/controllers/jubla/group/person_add_requests_controller.rb

@@ -0,0 +1,14 @@
+#  Copyright (c) 2012-2013, Jungwacht Blauring Schweiz. This file is part of
+#  hitobito_jubla and licensed under the Affero General Public License version 3
+#  or later. See the COPYING file at the top-level directory or at
+#  https://github.com/hitobito/hitobito_jubla.
+
+module Jubla::Group::PersonAddRequestsController
+  def activate
+    raise "shall never get called with jubla wagon"
+  end
+
+  def deactivate
+    raise "shall never get called with jubla wagon"
+  end
+end

app/models/jubla/group.rb

@@ -85,4 +85,10 @@ def alumni_filter_chain
       role_types: self.class.roles.collect(&:sti_name)
     }}
   end
+
+  def require_person_add_requests
+    true
+  end
+
+  alias_method :require_person_add_requests?, :require_person_add_requests
 end

app/views/group/person_add_requests/index.html.haml

@@ -0,0 +1,9 @@
+-#  Copyright (c) 2012-2013, Jungwacht Blauring Schweiz. This file is part of
+-#  hitobito_jubla and licensed under the Affero General Public License version 3
+-#  or later. See the COPYING file at the top-level directory or at
+-#  https://github.com/hitobito/hitobito_jubla.
+
+= render 'list'
+
+- if can?(:activate_person_add_requests, @group)
+  = render 'approvers'

db/migrate/20250219083234_require_add_requests_on_all_groups.rb

@@ -0,0 +1,5 @@
+class RequireAddRequestsOnAllGroups < ActiveRecord::Migration[7.1]
+  def change
+    execute "UPDATE groups SET require_person_add_requests = TRUE"
+  end
+end

lib/hitobito_jubla/wagon.rb

@@ -99,6 +99,7 @@ class Wagon < Rails::Engine
 
       GroupsController.include Jubla::GroupsController
       EventsController.include Jubla::EventsController
+      Group::PersonAddRequestsController.prepend Jubla::Group::PersonAddRequestsController
       Event::ApplicationMarketController.include Jubla::Event::ApplicationMarketController
       Event::QualificationsController.include Jubla::Event::QualificationsController
       Event::RegisterController.include Jubla::Event::RegisterController

spec/controllers/group/person_add_requests_controller_spec.rb

@@ -0,0 +1,26 @@
+#  Copyright (c) 2012-2013, Jungwacht Blauring Schweiz. This file is part of
+#  hitobito_jubla and licensed under the Affero General Public License version 3
+#  or later. See the COPYING file at the top-level directory or at
+#  https://github.com/hitobito/hitobito_jubla.
+
+require "spec_helper"
+
+describe Group::PersonAddRequestsController do
+  before { sign_in(people(:top_leader)) }
+
+  describe "#POST activate" do
+    it "raises" do
+      expect do
+        post :activate, params: { group_id: groups(:ch).id }
+      end.to raise_error "shall never get called with jubla wagon"
+    end
+  end
+
+  describe "#DELETE deactivate" do
+    it "raises" do
+      expect do
+        delete :deactivate, params: { group_id: groups(:ch).id }
+      end.to raise_error "shall never get called with jubla wagon"
+    end
+  end
+end