Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEJB: Prevent previous alumni-logic in new groups #147

Merged
merged 3 commits into from
Nov 7, 2024
Merged

NEJB: Prevent previous alumni-logic in new groups #147

merged 3 commits into from
Nov 7, 2024

Conversation

kronn
Copy link
Member

@kronn kronn commented Oct 30, 2024

fixes #131

Existing SimpleGroups need to be changed to the new type NejbSimpleGroup manually where needed.

@kronn kronn requested a review from TheWalkingLeek October 30, 2024 17:30
TheWalkingLeek
TheWalkingLeek requested changes Nov 4, 2024
View reviewed changes
Copy link
Member

@TheWalkingLeek TheWalkingLeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich bekomm noch einen Error beim Erstellen einer Rolle auf einer NejbSimpleGroup
uninitialized constant Group::NejbSimpleGroup::Alumnus

@kronn kronn requested a review from TheWalkingLeek November 5, 2024 15:21
@TheWalkingLeek TheWalkingLeek merged commit 9e1e757 into master Nov 7, 2024
9 checks passed
@TheWalkingLeek TheWalkingLeek deleted the feature/jubla-131-prevent-alumni-logic-in-nejb-tree branch November 7, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheWalkingLeek TheWalkingLeek TheWalkingLeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NEJB: bisherige Alumnus-Automatismen in NEJB-Grupppen deaktivieren
2 participants
@kronn @TheWalkingLeek