Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for recreate default event questions (required/multiple_choice) #87

Merged
merged 6 commits into from
Mar 12, 2024

Conversation

richardjubla
Copy link
Contributor

This pull request addresses the need to enhance the functionality of Event Questions within the hitobito_jubla project. It introduces the multiple_choices attribute to the existing Event::Question model, allowing for a more versatile set of questions during event creation.

@TheWalkingLeek TheWalkingLeek merged commit 1a2ba3d into hitobito:master Mar 12, 2024
3 checks passed
Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die Attribute required und multiple_choices wurden in der abzuarbeitenden Liste eingefügt, aber werden dann komplett ignoriert, und haben damit effektiv keine Wirkung.

@richardjubla
Copy link
Contributor Author

Mir erschliessen sich nicht alle Abhängigkeiten, in meiner Testumgebung werden die Attribute für einen neuen Kurs genau so übergeben, wie im File definiert:

hitobito-event-questions

@carlobeltrame
Copy link
Member

Ah, ja, stimmt, die Zeile 39 macht das, diese hatte ich übersehen. Alles gut in dem Fall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants