PEOPLE: Geschwister in Abteilung als computed value #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegosteiner
changed the title
diegosteiner
commented
Sep 12, 2023
diegosteiner
commented
Sep 12, 2023
diegosteiner
commented
Sep 12, 2023
diegosteiner
commented
Sep 14, 2023
| @@ -20,10 +20,18 @@ def roles_grouped | |||
| end | |||
| end | |||
|
|
|||
| def siblings_in_context(context) | |||
| family_member_finder.family_members_in_context(context, kind: :sibling) | |||
There was a problem hiding this comment.
ich habe die Logik in einen abgekapselten Service verschoben, weil sie doch an einigen verschiedenen Orten gebraucht wird und so einfacher getestet werden kann.
diegosteiner
changed the title
diegosteiner
force-pushed
the
#2147_siblings-in-layer
branch
from
ebfac4c to
a1e49ea
Compare
Comment on lines
13
to
32
| def family_members_in_layer(group, kind: :sibling) | ||
| Role.joins(person: :family_members) | ||
| .where(group: group.groups_in_same_layer, | ||
| person: { family_members: { kind: kind, other: person } }) | ||
| end | ||
|
|
||
| def family_members_in_event(event, kind: :sibling) | ||
| Event::Participation.joins(person: :family_members) | ||
| .where(person: { family_members: { kind: kind, other: person } }, | ||
| event: event) | ||
| end | ||
|
|
||
| def family_members_in_context(context, kind: :sibling) | ||
| case context | ||
| when Event | ||
| family_members_in_event(context, kind: kind) | ||
| when Group | ||
| family_members_in_layer(context, kind: kind) | ||
| end | ||
| end |
There was a problem hiding this comment.
Indentation ist hier zwei Spaces zu weit gerutscht
31 tasks
Co-authored-by: Carlo Beltrame <[email protected]>
TheWalkingLeek
force-pushed
the
#2147_siblings-in-layer
branch
from
bee82ff to
16e03cf
Compare
|
Nice merci! Hab noch die Indentation gefixt und rebased :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#hitobito#2147