Adjust public event display page #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheWalkingLeek
requested changes
Nov 26, 2024
There was a problem hiding this comment.
Fuktioniert alles und sieht imo gut aus. Wir wollen aber klar moeglichst davon weg kommen staendig saemtliche Views komplett redundant zu ueberschreiben.
Way to go ist laut meines Wissens das ganze in Partials zu verschachteln und diese Partials dann zu bearbeiten.
Bei public_events/show finde ich aber das komplette ueberschreiben voll i.O weil das ja eine komplett andere Optik haben soll
TheWalkingLeek
approved these changes
Nov 28, 2024
TheWalkingLeek
force-pushed
the
feature/1252/public-event-page
branch
from
3a05de6 to
3050de8
Compare
njaeggi
force-pushed
the
feature/1252/public-event-page
branch
from
3050de8 to
ea02e25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.