Send reset instructions on external event registration #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheWalkingLeek
force-pushed
the
feature/sac_1409_external_event_register_pw_reset
branch
2 times, most recently
from
4579413 to
21a3ab2
Compare
rnestler
reviewed
Dec 17, 2024
| expect(Devise::Mailer).to receive(:reset_password_instructions).and_call_original | ||
|
|
||
| expect do | ||
| put :register, params: {group_id: group.id, id: event.id, event_participation_contact_data: attrs} |
There was a problem hiding this comment.
Why a put and not a post?
| expect do | ||
| put :register, params: {group_id: group.id, id: event.id, event_participation_contact_data: attrs} | ||
| end.to change { Person.count }.by(1) | ||
| .and change { Group::AboBasicLogin::BasicLogin.count }.by(1) |
There was a problem hiding this comment.
Suggested change
| .and change { Group::AboBasicLogin::BasicLogin.count }.by(1) | |
| .and change { Group::AboBasicLogin::BasicLogin.count }.by(1) | |
| .and have_enqueued_mail(Devise::Mailer, :reset_password_instructions) |
There's also an event confirmation email that is sent, right?
| context "PUT register" do | ||
| context "with valid data" do | ||
| it "creates person and sends password reset instructions" do | ||
| event.update!(required_contact_attrs: []) |
There was a problem hiding this comment.
I'd move this in the let binding above.
| it "creates person and sends password reset instructions" do | ||
| event.update!(required_contact_attrs: []) | ||
|
|
||
| expect(Devise::Mailer).to receive(:reset_password_instructions).and_call_original |
There was a problem hiding this comment.
Suggested change
| expect(Devise::Mailer).to receive(:reset_password_instructions).and_call_original |
See suggestion about have_enqueud_mail.
There was a problem hiding this comment.
enqueued email klappt imho nicht, weil devise das direkt und nicht background job verschickt
| expect(person.roles.first.type).to eq(Group::AboBasicLogin::BasicLogin.sti_name) | ||
| is_expected.to redirect_to(new_group_event_participation_path(group, event)) | ||
| expect(flash[:notice]).to include "Deine persönlichen Daten wurden aufgenommen. Bitte ergänze nun noch die Angaben" | ||
| end |
There was a problem hiding this comment.
From the ticket "Newsletter (sollten schon passen)"
Can we add an expect for this?
amaierhofer
force-pushed
the
feature/sac_1409_external_event_register_pw_reset
branch
2 times, most recently
from
f1369e5 to
a2ba120
Compare
amaierhofer
force-pushed
the
feature/sac_1409_external_event_register_pw_reset
branch
from
a2ba120 to
317d45c
Compare
amaierhofer
deleted the
feature/sac_1409_external_event_register_pw_reset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.