Check for active membership when opening membership invoice form #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njaeggi
force-pushed
the
bug/1489/membership-invoice-form-without-membership
branch
3 times, most recently
from
0a9c387 to
f859962
Compare
codez
approved these changes
Jan 10, 2025
| @@ -29,7 +29,7 @@ | |||
| = f.date_field(:send_date, minDate: @invoice_form.min_date, maxDate: @invoice_form.max_send_date) | |||
|
|
|||
| = f.labeled(:section_id) do | |||
| = f.inline_radio_button :section_id, @person.sac_membership.stammsektion_role.group.layer_group.id, t(".mv_yearly_invoice"), true, checked: true | |||
| = f.inline_radio_button :section_id, @person.sac_membership.send((@person.sac_membership.stammsektion_role ? :stammsektion_role : :neuanmeldung_stammsektion_role)).group.layer_group.id, t(".mv_yearly_invoice"), true, checked: true | |||
There was a problem hiding this comment.
Könnte da nicht @invoice_form.stammsektion verwendet werden?
There was a problem hiding this comment.
Nein, dadurch entsteht ein Problem das wenn das Formular abgeschickt wird und invalid ist die Stammsektion nicht mehr korrekt gesetzt ist/ gesetzt werden kann.
Dafür gibt es auch einen Feature spec welcher jetzt failed: rspec spec/features/people/invoices_spec.rb:44
There was a problem hiding this comment.
👍 Den habe ich dann auch noch gefunden ;)
codez
force-pushed
the
bug/1489/membership-invoice-form-without-membership
branch
from
f859962 to
5970d97
Compare
…hip invoice form (#1489)
codez
force-pushed
the
bug/1489/membership-invoice-form-without-membership
branch
from
5970d97 to
046a44c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.