Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump version #85

Merged
merged 1 commit into from
Jul 31, 2024
Merged

chore: bump version #85

merged 1 commit into from
Jul 31, 2024

Conversation

hiwllc
Copy link
Owner

@hiwllc hiwllc commented Jul 31, 2024

[skip ci]

Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for uselessdev-datepicker ready!

Name Link
🔨 Latest commit 6b757e2
🔍 Latest deploy log https://app.netlify.com/sites/uselessdev-datepicker/deploys/66aab33c14de1a0007d8588a
😎 Deploy Preview https://deploy-preview-85--uselessdev-datepicker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hiwllc hiwllc merged commit 7f38011 into main Jul 31, 2024
4 of 5 checks passed
@hiwllc hiwllc deleted the chore-bump-version branch July 31, 2024 21:57
@hiwllc hiwllc restored the chore-bump-version branch July 31, 2024 21:58
@Philzen
Copy link
Contributor

Philzen commented Jul 31, 2024

@uselessdev I'm so sorry, but just trying out the v2.8.0 release in our project i'm getting:

web | Failed to resolve entry for package "@uselessdev/datepicker". The package may have incorrect main/module/exports specified in its package.json.
web | 12:22:51 AM [vite] Internal server error: Failed to resolve entry for package "@uselessdev/datepicker". The package may have incorrect main/module/exports specified in its package.json.
web |   Plugin: vite:import-analysis

Bottom line – project cannot be compiled at all using v2.8.0 as a dependency.

Using "@uselessdev/datepicker": "https://github.com/Philzen/datepicker.git#commit=097e011ed9df0febb2f219ea8c18f8b5d303c143", in the project's package.json works fine though (at least locally, on CI currently poses a challenge due to a yarn bug i'm still trying to wrap my head around, but that should be unrelated to the problem at hand).

@Philzen
Copy link
Contributor

Philzen commented Jul 31, 2024

@uselessdev just rm -rfed the node_modules folder, did a clean install and found that the 2.8.0 release does not ship any code at all as it does not include a dist/-folder (and furthermore the package.json does not seem to include the changes from #84).

grafik

@hiwllc
Copy link
Owner Author

hiwllc commented Jul 31, 2024

oh I probaly forget something, just a moment

@hiwllc
Copy link
Owner Author

hiwllc commented Jul 31, 2024

@Philzen can you try with v2.8.1 and let me know if it works

@Philzen
Copy link
Contributor

Philzen commented Aug 1, 2024

@Philzen can you try with v2.8.1 and let me know if it works

Happy to report v2.8.1 is working fine and includes the updated package.json. Many thanks again.

@Philzen
Copy link
Contributor

Philzen commented Aug 1, 2024

I've realized the Releases page (nor Tags) does not show 2.8.1 yet. In order to avoid confusion (and especially not have anybody accidentally trying to install the broken 2.8.0) i feel it may be vital to add it there.

Feeling a bit sorry for having caused all this late night kerfuffle on your side with this considerably non-critical fix – however on the upside this component won't cause any yarn install warnings anymore… and we've killed 50 % of the issues in this repo tonight 😆

@hiwllc
Copy link
Owner Author

hiwllc commented Aug 1, 2024

ah yes, I just published the version on npm before the release in github, it's updated now 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants