This repository has been archived by the owner on Oct 3, 2020. It is now read-only.
Switch to pathlib #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hjacobs Marked this as WIP as I clean up the tests, I just wanted to make sure this is what you were looking for? Basically I found once I started replacing some references it made sense to carry all the way through, that is to only interact with Paths and not strings for as long as I can. |
hjacobs
reviewed
Apr 3, 2020
lukemassa
force-pushed
the
switch_to_pathlib
branch
from
e1e77ee to
65853aa
Compare
|
Apologies for the delay here, this is now finished: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching code from using os.path to using Pathlib (per request in #55)