Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP:adds a verbose descriptior to pagination number #1861

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

WIP:adds a verbose descriptior to pagination number #1861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a8a59db
adds a verbose descriptior to pagination number
StoneBenHMCTS Feb 6, 2025
b53a9a0
update aria-label attribute
StoneBenHMCTS Feb 7, 2025
1c92621
removes nav role attr from the ul for Sonar
StoneBenHMCTS Feb 7, 2025
e1892f4
updates the wording to be read out
StoneBenHMCTS Feb 7, 2025
cefb4e9
adds a more verbose label
StoneBenHMCTS Feb 10, 2025
979a1c5
updates the previous and next aria labels
StoneBenHMCTS Feb 10, 2025
73b1a75
Merge branch 'master' into feature/exui-1593
StoneBenHMCTS Feb 10, 2025
97df882
puts the values back to be none hard-coded
StoneBenHMCTS Feb 11, 2025
257977b
updates pagination based on comments
StoneBenHMCTS Feb 11, 2025
c0a6019
Merge branch 'master' into feature/exui-1593
StoneBenHMCTS Feb 12, 2025
0b30878
fixes build error
StoneBenHMCTS Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@hmcts/ccd-case-ui-toolkit",
"version": "7.1.37",
"version": "7.1.36-pagination-descriptor-v7",
"engines": {
"node": ">=18.19.0"
},
Expand Down
2 changes: 1 addition & 1 deletion projects/ccd-case-ui-toolkit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@hmcts/ccd-case-ui-toolkit",
"version": "7.1.37",
"version": "7.1.36-pagination-descriptor-v7",
"engines": {
"node": ">=18.19.0"
},
Expand Down
4 changes: 2 additions & 2 deletions projects/ccd-case-ui-toolkit/src/lib/shared/components/pagination/pagination.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
[attr.aria-label]="previousLabel + ' ' + screenReaderPageLabel | rpxTranslate">
{{ previousLabel | rpxTranslate }} <span class="show-for-sr">{{ screenReaderPageLabel | rpxTranslate }}</span>
</a>
<span *ngIf="p.isFirstPage()">
<span *ngIf="p.isFirstPage()" [attr.aria-label]="previousLabel + ' page' | rpxTranslate">
{{ previousLabel | rpxTranslate }} <span class="show-for-sr">{{ screenReaderPageLabel | rpxTranslate }}</span>
</span>
</li>
Expand All @@ -18,7 +18,7 @@
<li [class.current]="p.getCurrent() === page.value" [class.ellipsis]="page.label === '...'"
*ngFor="let page of p.pages">
<a tabindex="0" (keyup.enter)="p.setCurrent(page.value)" (click)="p.setCurrent(page.value)"
*ngIf="p.getCurrent() !== page.value">
*ngIf="p.getCurrent() !== page.value" [attr.aria-label]="(page.label === '...') ? ('Change pagination range' | rpxTranslate) : ('Page ' | rpxTranslate) + (page.label | number:'')">
<span class="show-for-sr">{{ screenReaderPageLabel | rpxTranslate }} </span>
<span>{{ (page.label === '...') ? page.label : (page.label | number:'') }}</span>
</a>
Expand Down