Skip to content

Commit

Permalink
CIV-15890 better logging and failure screenshot capture for e2e (#5098)
Browse files Browse the repository at this point in the history
* initial commit with github ci changes

* failing a test

* Update claimCreation.js

* revert fail test changes

* few memory bump up

* modifying log to move it under when the application is shuttered

* correcting camel case ingressHost
  • Loading branch information
vasudevganesanhmcts authored Nov 21, 2024
1 parent e739451 commit dc1a23c
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 12 deletions.
19 changes: 10 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,18 @@ jobs:
run: yarn install && yarn playwright install
- name: Build
run: yarn build
- name: Starting WireMock
run: yarn wiremock:start &
- name: Starting CUI
run: yarn start:e2e &
- name: Waiting CUI to get ready
run: sleep 10
- name: Executing e2e tests
run: yarn test:e2e
- name: Starting WireMock , starting ui , wait and run e2e test
run: |
yarn wiremock:start &
sleep 2
yarn start:e2e &
sleep 25
yarn test:e2e
- name: Upload e2e test artifacts
uses: actions/upload-artifact@v4
if: always()
with:
name: integration-tests-results
path: test-results/functional
path: |
test-results/functional
src/test/functionalTests/test-results
2 changes: 1 addition & 1 deletion charts/civil-citizen-ui/values.aat.template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ aac-manage-case-assignment:
imagePullPolicy: Always
releaseNameOverride: ${SERVICE_NAME}-aac-manage-case-assignment
image: hmctspublic.azurecr.io/aac/manage-case-assignment:latest
ingresshost: civil-cui-manage-case-assignment-staging.aat.platform.hmcts.net
ingressHost: civil-cui-manage-case-assignment-staging.aat.platform.hmcts.net
environment:
IDAM_API_URL: https://idam-api.aat.platform.hmcts.net
IDAM_OIDC_URL: https://idam-web-public.aat.platform.hmcts.net
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ civil-service:
image: 'hmctspublic.azurecr.io/civil/service:latest'
imagePullPolicy: Always
ingressHost: ${SERVICE_NAME}-civil-service.preview.platform.hmcts.net
devcpuRequests: 500m
devcpuRequests: 1000m
devmemoryRequests: 2048Mi
devmemoryLimits: 4096Mi
keyVaults:
Expand Down
3 changes: 3 additions & 0 deletions charts/civil-citizen-ui/values.preview.template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,9 @@ civil-general-applications:
releaseNameOverride: ${SERVICE_NAME}-general-applications
ingressHost: ${SERVICE_NAME}-general-applications.preview.platform.hmcts.net
imagePullPolicy: Always
devcpuRequests: 1000m
devmemoryRequests: 2048Mi
devmemoryLimits: 4096Mi
keyVaults:
civil:
resourceGroup: civil
Expand Down
2 changes: 1 addition & 1 deletion src/main/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,8 @@ app.use((_req, res, next) => {

const checkServiceAvailability = async (_req: express.Request, res: express.Response, next: express.NextFunction) => {
const serviceShuttered = await isServiceShuttered();
logger.info(`Checking for service availability... ${serviceShuttered}`);
if (serviceShuttered) {
logger.info(`service is shuttered... ${serviceShuttered}`);
res.render('service-unavailable');
} else {
next();
Expand Down

0 comments on commit dc1a23c

Please sign in to comment.