Merge pull request #3 from hmhco/SIS-12146a

Sis 12146a

.npmignore

@@ -0,0 +1,14 @@
+_assets
+build
+bower.json
+dev
+docs
+examples
+extras
+icon.png
+lib/**-NEXT**.js
+spikes
+src
+tests
+tutorials
+VERSIONS.txt

ISSUE_TEMPLATE.md

@@ -0,0 +1,27 @@
+### TODO
+- [ ] Is this a question or bug? [Stack Overflow](https://stackoverflow.com/questions/tagged/createjs) is a much better place to ask any questions you may have.
+
+- [ ] Did you search the [issues](https://github.com/CreateJS/SoundJS/issues) to see if someone else has already reported your issue? If yes, please add more details if you have any!
+
+- [ ] If you're using an older [version](https://github.com/CreateJS/SoundJS/blob/master/VERSIONS.txt), have you tried the latest?
+
+- [ ] If you're requesting a new feature; provide as many details as you can. Why do you want this feature? Do you have ideas for how this feature should be implemented? Pseudocode is always welcome!
+
+
+### Issue Details
+* Version used (Ex; 1.0): 
+
+
+* Describe whats happening (Include any relevant console errors, a [Gist](https://gist.github.com/) is preferred for longer errors):
+
+
+
+* OS & Browser version *(Please be specific)* (Ex; Windows 10 Home, Chrome 62.0.3202.94):
+
+
+
+* Do you know of any workarounds?
+
+
+
+* Provide any extra details that will help us fix your issue. Including a link to a [CodePen.io](https://codepen.io) or [JSFiddle.net](https://jsfiddle.net) example that shows the issue in isolation will greatly increase the chance of getting a quick response.

README.md

@@ -2,8 +2,9 @@
 
 SoundJS is a library to make working with audio on the web easier. It provides a consistent API for playing audio in
 different browsers, including using a target plugin model to provide an easy way to provide additional audio plugins
-like a Flash fallback. A mechanism has been provided for easily tying in audio preloading to
-[PreloadJS](http://createjs.com/preloadjs/).
+like a Flash fallback (included, but must be used separately from the combined/minified version).
+
+A mechanism has been provided for easily tying in audio preloading to [PreloadJS](http://createjs.com/preloadjs/).
 
 
 ## Example

VERSIONS.txt

@@ -1,8 +1,30 @@
-Version NEXT [Not yet released]
+Version 1.0.0 (September 14, 2017)
 ****************************************************************************************************
-* Changed XHR error conditions to only include 400-599. Specifically removed status=0 as an error,
+CRITICAL
+- removed deprecated properties, particularly getValue/setValue properties, in favour of .value
+	this particularly affects instance and global properties like mute, volume, pan, etc.
+- removed deprecated TYPE duplicates, notably the loader types (LoadQueue.SOUND, AbstractLoader.SOUND)
+	in place of the Types.SOUND, and request methods (LoadQueue.POST, AbstractLoader.POST) in place
+	of Methods.POST.
+- Deprecated get/set methods are now protect with an underscore (eg _setEnabled)
+	The deprecated methods and properties will still work, but will display a console warning when used.
+- Sound.play is no longer overloaded, and only takes a source and an initialization object
+	(or PlayPropsConfig) instead of a bunch of arguments. A console warning will be displayed if  the
+	old approach is used, and additional arguments will be ignored.
+- Changed version naming to use soundjs.js, instead of containing the version number
+
+*****
+- changed XHR error conditions to only include 400-599. Specifically removed status=0 as an error,
   	which affects compiled applications.
-* Fixed issue where values don't get appended to GET requests in XHRRequest
+- fixed issue where values don't get appended to GET requests in XHRRequest
+- added "touchstart" as an audio unlocking event, which seems to be the best for iOS
+- checked if preload candidates are videos, since SoundJS mistakenly handles these when they are mp4.
+- added missing Methods and Types classes from recent PreloadJS changes
+- handled case where audio duration returned < 0, resulting in a DOM Error
+- fixed issue where new instances wouldn't get the global mute/volume (thanks @PythonFanboy)
+- added a shared createjs.deprecate() method, which wraps old methods and property getter/setters to display
+	a console warning when used.
+- fixed an issue with the initial 1.0.0 build that used a deprecated property that was improperly removed
 
 
 Version 0.6.2 [November 26, 2015]

bower.json

@@ -1,15 +1,14 @@
 {
 	"name": "SoundJS",
-	"version": "0.6.3",
+	"version": "1.0.0",
 	"homepage": "https://github.com/CreateJS/SoundJS",
 	"authors": [
 		"lannymcnie",
-		"OJayRobinson",
 		"gskinner",
 		"wdamien"
 	],
 	"description": "A Javascript library for working with Audio. Features a simple interface as the front end to multiple audio APIs via a plugin model. Currently supports WebAudio, HTML5 Audio, and a Flash fallback. Part of the CreateJS suite of libraries.",
-	"main": "lib/soundjs-0.6.3.combined.js",
+	"main": "lib/soundjs.js",
 	"keywords": [
 		"sound",
 		"audio",

build/Gruntfile.js

@@ -8,10 +8,11 @@ module.exports = function (grunt) {
 
 				// Default values
 				version: 'NEXT',
+				fileVersion: '-<%= version %>',
 				name: 'soundjs',
 
 				// Setup doc names / paths.
-				docsName: '<%= pkg.name %>_docs-<%= version %>',
+				docsName: '<%= pkg.name %>_docs<%= fileVersion %>',
 				docsZip: "<%= docsName %>.zip",
 
 				// Setup Uglify for JS minification.
@@ -30,9 +31,9 @@ module.exports = function (grunt) {
 					},
 					build: {
 						files: {
-							'output/<%= pkg.name.toLowerCase() %>-<%= version %>.min.js': getConfigValue('source'),
-							'output/flashaudioplugin-<%= version %>.min.js': getConfigValue('flashaudioplugin_source'),
-							'output/cordovaaudioplugin-<%= version %>.min.js': getConfigValue('cordovaaudioplugin_source'),
+							'output/<%= pkg.name.toLowerCase() %><%= fileVersion %>.min.js': getConfigValue('source'),
+							'output/flashaudioplugin<%= fileVersion %>.min.js': getConfigValue('flashaudioplugin_source'),
+							'output/cordovaaudioplugin<%= fileVersion %>.min.js': getConfigValue('cordovaaudioplugin_source'),
 						}
 					}
 				},
@@ -71,13 +72,13 @@ module.exports = function (grunt) {
 					},
 					build: {
 						files: {
-							'output/<%= pkg.name.toLowerCase() %>-<%= version %>.combined.js': combineSource([
+							'output/<%= pkg.name.toLowerCase() %><%= fileVersion %>.js': combineSource([
 										{cwd: '', config:'config.json', source:'source'}
 									]),
-							'output/flashaudioplugin-<%= version %>.combined.js': combineSource([
+							'output/flashaudioplugin<%= fileVersion %>.js': combineSource([
 																	{cwd: '', config:'config.json', source:'flashaudioplugin_source'}
 																]),
-							'output/cordovaaudioplugin-<%= version %>.combined.js': combineSource([
+							'output/cordovaaudioplugin<%= fileVersion %>.js': combineSource([
 																	{cwd: '', config:'config.json', source:'cordovaaudioplugin_source'}
 																])
 						}
@@ -135,7 +136,7 @@ module.exports = function (grunt) {
 					},
 					src: {
 						files: [
-							{expand: true, cwd:'./output/', src: '*<%=version %>*.js', dest: '../lib/'}
+							{expand: true, cwd:'./output/', src: '*<%=fileVersion %>*.js', dest: '../lib/'}
 						]
 					}
 				},
@@ -315,6 +316,7 @@ module.exports = function (grunt) {
 	 */
 	grunt.registerTask('setVersion', function () {
 		grunt.config.set('version', grunt.config.get('pkg').version);
+		grunt.config.set('fileVersion', '');
 	});
 
 	/**

build/config.json

@@ -1,56 +1,60 @@
-{
-	"source": [
-		"../src/soundjs/version.js",
-
-		"../src/createjs/utils/extend.js",
-		"../src/createjs/utils/promote.js",
-		"../src/createjs/utils/IndexOf.js",
-		"../src/createjs/utils/Proxy.js",
-		"../src/createjs/utils/BrowserDetect.js",
-		"../src/createjs/events/EventDispatcher.js",
-		"../src/createjs/events/Event.js",
-
-		"../src/createjs/events/ErrorEvent.js",
-		"../src/preloadjs/events/ProgressEvent.js",
-		"../src/preloadjs/data/LoadItem.js",
-		"../src/preloadjs/utils/RequestUtils.js",
-		"../src/preloadjs/loaders/AbstractLoader.js",
-		"../src/preloadjs/loaders/AbstractMediaLoader.js",
-		"../src/preloadjs/net/AbstractRequest.js",
-		"../src/preloadjs/net/TagRequest.js",
-		"../src/preloadjs/net/MediaTagRequest.js",
-		"../src/preloadjs/net/XHRRequest.js",
-		"../src/preloadjs/loaders/SoundLoader.js",
-
-		"../src/soundjs/data/AudioSprite.js",
-		"../src/soundjs/data/PlayPropsConfig.js",
-		"../src/soundjs/Sound.js",
-		"../src/soundjs/AbstractSoundInstance.js",
-		"../src/soundjs/AbstractPlugin.js",
-		"../src/soundjs/webAudio/WebAudioLoader.js",
-		"../src/soundjs/webAudio/WebAudioSoundInstance.js",
-		"../src/soundjs/webAudio/WebAudioPlugin.js",
-		"../src/soundjs/binarywebaudio/BinaryWebAudioSoundInstance.js",
-		"../src/soundjs/binarywebaudio/BinaryWebAudioPlugin.js",
-		"../src/soundjs/htmlaudio/HTMLAudioTagPool.js",
-		"../src/soundjs/htmlaudio/HTMLAudioSoundInstance.js",
-		"../src/soundjs/htmlaudio/HTMLAudioPlugin.js"
-	],
-
-	"flashaudioplugin_source": [
-		"../src/swfobject.js",
-		"../src/soundjs/flashaudio/FlashAudioLoader.js",
-		"../src/soundjs/flashaudio/FlashAudioSoundInstance.js",
-		"../src/soundjs/flashaudio/FlashAudioPlugin.js",
-		"../src/soundjs/version_flashplugin.js"
-	],
-
-	"cordovaaudioplugin_source": [
-		"../src/soundjs/cordovaaudio/CordovaAudioLoader.js",
-		"../src/soundjs/cordovaaudio/CordovaAudioSoundInstance.js",
-		"../src/soundjs/cordovaaudio/CordovaAudioPlugin.js",
-		"../src/soundjs/version_cordovaplugin.js"
-	],
-
-	"docs_out_path":"./output/SoundJSDocs/"
-}
+{
+	"source": [
+		"../src/soundjs/version.js",
+
+		"../src/createjs/utils/extend.js",
+		"../src/createjs/utils/promote.js",
+		"../src/createjs/utils/deprecate.js",
+		"../src/createjs/utils/indexOf.js",
+		"../src/createjs/utils/proxy.js",
+		"../src/createjs/utils/BrowserDetect.js",
+		"../src/createjs/events/EventDispatcher.js",
+		"../src/createjs/events/Event.js",
+		"../src/createjs/events/ErrorEvent.js",
+
+		"../src/preloadjs/events/ProgressEvent.js",
+		"../src/preloadjs/data/LoadItem.js",
+		"../src/preloadjs/data/Methods.js",
+		"../src/preloadjs/data/Types.js",
+		"../src/preloadjs/utils/Elements.js",
+		"../src/preloadjs/utils/DomUtils.js",
+		"../src/preloadjs/utils/RequestUtils.js",
+		"../src/preloadjs/utils/URLUtils.js",
+		"../src/preloadjs/loaders/AbstractLoader.js",
+		"../src/preloadjs/loaders/AbstractMediaLoader.js",
+		"../src/preloadjs/net/AbstractRequest.js",
+		"../src/preloadjs/net/TagRequest.js",
+		"../src/preloadjs/net/MediaTagRequest.js",
+		"../src/preloadjs/net/XHRRequest.js",
+		"../src/preloadjs/loaders/SoundLoader.js",
+
+		"../src/soundjs/data/AudioSprite.js",
+		"../src/soundjs/data/PlayPropsConfig.js",
+		"../src/soundjs/Sound.js",
+		"../src/soundjs/AbstractSoundInstance.js",
+		"../src/soundjs/AbstractPlugin.js",
+		"../src/soundjs/webaudio/WebAudioLoader.js",
+		"../src/soundjs/webaudio/WebAudioSoundInstance.js",
+		"../src/soundjs/webaudio/WebAudioPlugin.js",
+    	"../src/soundjs/htmlaudio/HTMLAudioTagPool.js",
+    	"../src/soundjs/htmlaudio/HTMLAudioSoundInstance.js",
+    	"../src/soundjs/htmlaudio/HTMLAudioPlugin.js"
+	],
+
+	"flashaudioplugin_source": [
+		"../src/swfobject.js",
+        "../src/soundjs/flashaudio/FlashAudioLoader.js",
+		"../src/soundjs/flashaudio/FlashAudioSoundInstance.js",
+		"../src/soundjs/flashaudio/FlashAudioPlugin.js",
+        "../src/soundjs/version_flashplugin.js"
+	],
+
+	"cordovaaudioplugin_source": [
+        "../src/soundjs/cordovaaudio/CordovaAudioLoader.js",
+		"../src/soundjs/cordovaaudio/CordovaAudioSoundInstance.js",
+		"../src/soundjs/cordovaaudio/CordovaAudioPlugin.js",
+        "../src/soundjs/version_cordovaplugin.js"
+	],
+
+	"docs_out_path":"./output/SoundJSDocs/"
+}

build/createjsTheme/assets/scss/settings/fonts.scss

@@ -44,7 +44,7 @@ $fontFamily-secondary: 'Proxima Nova', sans-serif;
 //	Weights: 400, 500
 
 //	Monospace Font
-@import url("http://fonts.googleapis.com/css?family=Source+Code+Pro&subset=latin,latin-ext");
+@import url("https://fonts.googleapis.com/css?family=Source+Code+Pro&subset=latin,latin-ext");
 $fontFamily-monospace: 'Source Code Pro', monospace;
 //	Weights: 400
 

build/package.json

@@ -1,6 +1,6 @@
 {
   "name": "SoundJS",
-  "version": "0.6.3",
+  "version": "1.0.0",
   "description": "SoundJS Docs",
   "url": "http://www.createjs.com/soundjs",
   "logo": "assets/docs-icon-SoundJS.png",

examples/00_Basics.html

@@ -41,7 +41,7 @@ <h2>Sorry!</h2>
 		Thank you.</p>
 </div>
 
-<script type="text/javascript" src="../lib/soundjs-NEXT.combined.js"></script>
+<script type="text/javascript" src="../lib/soundjs-NEXT.js"></script>
 <!-- We also provide hosted minified versions of all CreateJS libraries.
  http://code.createjs.com -->
 

examples/01_LoadWithPreloadJS.html

@@ -61,9 +61,9 @@ <h2>Sorry!</h2>
 </div>
 
 <script type="text/javascript" src="../_assets/libs/preloadjs-NEXT.min.js"></script>
-<script type="text/javascript" src="../lib/soundjs-NEXT.combined.js"></script>
+<script type="text/javascript" src="../lib/soundjs-NEXT.js"></script>
 <!-- Note: FlashAudioPlugin is only needed to support older browsers -->
-<script type="text/javascript" src="../lib/flashaudioplugin-NEXT.combined.js"></script>
+<script type="text/javascript" src="../lib/flashaudioplugin-NEXT.js"></script>
 
 <!-- We also provide hosted minified versions of all CreateJS libraries.
 	http://code.createjs.com -->