Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull code from sound js master #2

Open
wants to merge 83 commits into
base: SIS-12146
Choose a base branch
from
Open

Pull code from sound js master #2

wants to merge 83 commits into from

Conversation

Gousalya-hmh
Copy link
Collaborator

Pull code from the sound js master

Lanny McNie and others added 30 commits October 27, 2016 11:51
Updated shared classes to the latest
732bf96
Updated docs and libs to NEXT
ef1d8c7
Added touchstart event support for mobile audio unlocking
2b0bb62
Checked if preload candidates are videos, since SoundJS mistakenly ha…
4851517 
…ndles these when they are mp4.
Merged in latest shared files from PreloadJS/EaselJS
5000867
Added missing Methods and Types classes from recent PreloadJS changes
64785de
Added remaining PreloadJS dependencies.
508bceb
Added latest PreloadJS minified file (required for some demos)
c4950ef
Updated latest libs and docs
41ca6cf
Handled case where the duration returns < 0 in a web audio context, r…
c813a7b 
…esulting in a DOM error
PreloadJS fix where loading content could still scale the browser.
d3de015
Updated minified versions + VERSION.txt
4b23598
Minor adjustment to earlier fix, which caused resume() to always rese…
870d9d8 
…t position.
Updated min files.
cd9d7a0
@NuclearCookie
An iOS hack should only exist on iOS
aa95123
@NuclearCookie
Fixed case of folder to correctly build with grunt on case sensitive OS
6ce1ebe
Merge pull request #262 from FishingCactus/fix/edge_error
63b8f77 
An iOS hack should only exist on iOS
@lannymcnie
Updated shared classes from EaselJS & PreloadJS
aabf145
@lannymcnie
Minor demo updates
a5661f3
@lannymcnie
Updates to shared classes from PreloadJS
5a90eda
@lannymcnie
Updated asset libraries used in demos
e1ad346
@lannymcnie
Removed the deprecated capabilities method (in favour of the getter/p…
41c8c43 
…roperty)
@lannymcnie
Removed deprecated defaultNumChannels (an object pool is used now)
f0cbb83
@lannymcnie
Removed setVolume/getVolume and setMute/getMute in favour of volume/m…
a46b345 
…uted getter/setters
@lannymcnie
Removed deprecated initialize method (was already commented out)
7f935bc
@lannymcnie
Removed deprecated get/set methods, in place of protected methods (ge…
084c6be 
…t -> _get)
@lannymcnie
Removed deprecated properties on play()
5f93934
@lannymcnie
Missed a few @deprecated comments
472260d
@lannymcnie
Updated shared classes from PreloadJS
c393d16
@lannymcnie
Updated deprecated method usage on demos
ca90905
lannymcnie and others added 28 commits September 15, 2017 14:19
@lannymcnie
Updated README
ff25923
@lannymcnie
Updated VERSIONS
0defb6a
@lannymcnie
Minor demo improvements
e10a583
@lannymcnie
Changed all demos and supporting files to the *new* correct naming of…
9b831ef 
… the SoundJS combined file.
@lannymcnie
Tweak the build to only append -NEXT when running a grunt next build.
0f45ba5
@wdamien
Add correct path for jsdelivr.
08b449b
@wdamien
1.0.1
1019c8f
@lannymcnie
Updated bower main to new renamed file
4859132
@lannymcnie
Merge branch 'master' of https://github.com/CreateJS/SoundJS
f949114
@lannymcnie
Internal preloading was using deprecated method name
33b1303
@lannymcnie
Missing deprecated handling (changed to underscore syntax for protect…
dc873d1 
…ed methods)
@lannymcnie
Updated libs
640d610
@lannymcnie
New libs with Sound 1.0 fix
863a40d
@lannymcnie
Updated SoundJS version for NPM
2ef2de8
@lannymcnie
Minor demo issues
ed23b6b
@lannymcnie
Updated https in tutorials
a95abb5
@lannymcnie
Fixed https in doc assets
83b1517
@lannymcnie
Fixed possible issues when internal preloading completes.
a83ffe7
@lannymcnie
Typo in comments.
c49fd3f
@wdamien
Create ISSUE_TEMPLATE.md
f08592e
@lannymcnie
Missing class documentation
c4c7522
@lannymcnie
Minor fix for canceled handling
abbc98b
@lannymcnie
Doc'd deprecated methods
357d48c
@lannymcnie
Update to latest shared class
482b752
@lannymcnie
Minor update to deprecated docs
416db50
@timgates42
docs: Fix simple typo, ammount -> amount
930ba01 
There is a small typo in examples/Game/Ship.js, examples/Game/SpaceRock.js.

Should read `amount` rather than `ammount`.
@danzen
Merge pull request #325 from timgates42/bugfix_typo_amount
999d586 
docs: Fix simple typo, ammount -> amount
@danzen
Adjusted XHR test and added warning reply
5213ac5 
The XHR test was giving an error - what do you know, the try catch does not work anymore.  So adjusted the test to just assume it is not XHR if local.  

Also we are getting a warning to not play sounds before interacting.  We are not playing but are testing.  So follow up with a warning that the sounds are ready to play to make whoever is looking at the warnings feel better.
@Gousalya-hmh Gousalya-hmh requested a review from sanjayhmh June 17, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sboobalans sboobalans sboobalans approved these changes

@sanjayhmh sanjayhmh Awaiting requested review from sanjayhmh

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Gousalya-hmh @sboobalans @NuclearCookie @lannymcnie @wdamien @timgates42 @danzen