Skip to content

Commit

Permalink
Rename expression tests to focus on operator
Browse files Browse the repository at this point in the history
  • Loading branch information
johannaengland committed Nov 17, 2023
1 parent e045c42 commit 4a61445
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions tests/integration/web/alertprofiles_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -405,10 +405,12 @@ def test_alertprofiles_add_expression_with_multiple_non_valid_ip_addresses_shoul
).exists()
assert f"Invalid IP address: {invalid_ip}" in smart_str(response.content)

def test_alertprofiles_add_expression_with_multiple_alert_types_should_succeed(
def test_alertprofiles_add_expression_with_in_condition_should_succeed(
self, client, dummy_filter
):
"""Tests that an expression with multiple alert types can be added"""
"""Tests that an expression with an in condition can be added, alert type is
just an example
"""
string_match_field = MatchField.objects.get(name="Alert type")
url = reverse("alertprofiles-filters-saveexpression")
data = {
Expand All @@ -429,10 +431,12 @@ def test_alertprofiles_add_expression_with_multiple_alert_types_should_succeed(
response.content
)

def test_alertprofiles_add_expression_with_valid_group_should_succeed(
def test_alertprofiles_add_expression_with_equals_condition_should_succeed(
self, client, dummy_filter
):
"""Tests that an expression with a valid group can be added"""
"""Tests that an expression with an equals condition can be added, group is
just an example
"""
group_match_field = MatchField.objects.get(name="Group")
url = reverse("alertprofiles-filters-saveexpression")
data = {
Expand Down

0 comments on commit 4a61445

Please sign in to comment.