Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIPP-1818: Use update session repository #514

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

HIPP-1818: Use update session repository #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/controllers/myapis/update/UpdateApiAddPrefixesController.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import pages.myapis.update.UpdateApiAddPrefixesPage
import play.api.data.Form
import play.api.i18n.{I18nSupport, MessagesApi}
import play.api.mvc.{Action, AnyContent, MessagesControllerComponents}
import repositories.ProduceApiSessionRepository
import repositories.UpdateApiSessionRepository
import uk.gov.hmrc.play.bootstrap.frontend.controller.FrontendBaseController
import viewmodels.myapis.produce.ProduceApiAddPrefixesViewModel
import views.html.myapis.produce.ProduceApiAddPrefixesView
Expand All @@ -38,10 +38,10 @@ import scala.concurrent.{ExecutionContext, Future}
class UpdateApiAddPrefixesController @Inject()(
override val messagesApi: MessagesApi,
config: FrontendAppConfig,
sessionRepository: ProduceApiSessionRepository,
sessionRepository: UpdateApiSessionRepository,
navigator: Navigator,
identify: IdentifierAction,
getData: ProduceApiDataRetrievalAction,
getData: UpdateApiDataRetrievalAction,
requireData: DataRequiredAction,
val controllerComponents: MessagesControllerComponents,
formProvider: ProduceApiAddPrefixesFormProvider,
Expand Down
22 changes: 11 additions & 11 deletions test/controllers/myapis/update/UpdateApiAddPrefixesControllerSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import play.api.inject.bind
import play.api.mvc.Call
import play.api.test.FakeRequest
import play.api.test.Helpers.*
import repositories.ProduceApiSessionRepository
import repositories.UpdateApiSessionRepository
import viewmodels.myapis.produce.ProduceApiAddPrefixesViewModel
import views.html.myapis.produce.ProduceApiAddPrefixesView

Expand All @@ -42,7 +42,7 @@ class UpdateApiAddPrefixesControllerSpec extends SpecBase with MockitoSugar {

private def onwardRoute = Call("GET", "/foo")

private lazy val produceApiAddPrefixesRoute = updateApiRoutes.UpdateApiAddPrefixesController.onPageLoad(NormalMode).url
private lazy val updateApiAddPrefixesRoute = updateApiRoutes.UpdateApiAddPrefixesController.onPageLoad(NormalMode).url

private val formProvider = new ProduceApiAddPrefixesFormProvider()
private val form = formProvider()
Expand All @@ -55,7 +55,7 @@ class UpdateApiAddPrefixesControllerSpec extends SpecBase with MockitoSugar {
val application = applicationBuilder(userAnswers = Some(emptyUserAnswers)).build()

running(application) {
val request = FakeRequest(GET, produceApiAddPrefixesRoute)
val request = FakeRequest(GET, updateApiAddPrefixesRoute)

val result = route(application, request).value

Expand All @@ -74,7 +74,7 @@ class UpdateApiAddPrefixesControllerSpec extends SpecBase with MockitoSugar {
val application = applicationBuilder(userAnswers = Some(userAnswers)).build()

running(application) {
val request = FakeRequest(GET, produceApiAddPrefixesRoute)
val request = FakeRequest(GET, updateApiAddPrefixesRoute)

val view = application.injector.instanceOf[ProduceApiAddPrefixesView]
val viewModel = ProduceApiAddPrefixesViewModel(updateApiRoutes.UpdateApiAddPrefixesController.onSubmit(NormalMode))
Expand All @@ -87,21 +87,21 @@ class UpdateApiAddPrefixesControllerSpec extends SpecBase with MockitoSugar {

"must redirect to the next page when valid data is submitted" in {

val mockProduceApiSessionRepository = mock[ProduceApiSessionRepository]
val mockUpdateApiSessionRepository = mock[UpdateApiSessionRepository]

when(mockProduceApiSessionRepository.set(any())).thenReturn(Future.successful(true))
when(mockUpdateApiSessionRepository.set(any())).thenReturn(Future.successful(true))

val application =
applicationBuilder(userAnswers = Some(emptyUserAnswers))
.overrides(
bind[Navigator].toInstance(new FakeNavigator(onwardRoute)),
bind[ProduceApiSessionRepository].toInstance(mockProduceApiSessionRepository)
bind[UpdateApiSessionRepository].toInstance(mockUpdateApiSessionRepository)
)
.build()

running(application) {
val request =
FakeRequest(POST, produceApiAddPrefixesRoute)
FakeRequest(POST, updateApiAddPrefixesRoute)
.withFormUrlEncodedBody(("value", "true"))

val result = route(application, request).value
Expand All @@ -117,7 +117,7 @@ class UpdateApiAddPrefixesControllerSpec extends SpecBase with MockitoSugar {

running(application) {
val request =
FakeRequest(POST, produceApiAddPrefixesRoute)
FakeRequest(POST, updateApiAddPrefixesRoute)
.withFormUrlEncodedBody(("value", "invalid value"))

val boundForm = form.bind(Map("value" -> "invalid value"))
Expand All @@ -136,7 +136,7 @@ class UpdateApiAddPrefixesControllerSpec extends SpecBase with MockitoSugar {
val application = applicationBuilder(userAnswers = None).build()

running(application) {
val request = FakeRequest(GET, produceApiAddPrefixesRoute)
val request = FakeRequest(GET, updateApiAddPrefixesRoute)

val result = route(application, request).value

Expand All @@ -151,7 +151,7 @@ class UpdateApiAddPrefixesControllerSpec extends SpecBase with MockitoSugar {

running(application) {
val request =
FakeRequest(POST, produceApiAddPrefixesRoute)
FakeRequest(POST, updateApiAddPrefixesRoute)
.withFormUrlEncodedBody(("value", Alpha.toString))

val result = route(application, request).value
Expand Down