Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIL-1362 Update SubmitUktr to use header for pillar2Id #40

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

JamesMMiller
Copy link
Contributor

@JamesMMiller JamesMMiller commented Nov 28, 2024

Summary

Added error handling and test cases for invalid JSON submissions to the UK Tax Return endpoint.

Changes

  • Added custom JSON decoder action to handle invalid JSON payloads
  • Added new error cases with corresponding test data:
    • 401 (Unauthorized)
    • 403 (Forbidden)
    • 404 (Not Found)
    • 415 (Unsupported Media Type)
    • 422 (Unprocessable Entity)
    • 500 (Internal Server Error)
  • Updated README to use a table format for response scenarios

Testing

  • Added test cases for each error scenario
  • Added test for malformed JSON input

@platops-pr-bot
Copy link

@JamesMMiller JamesMMiller changed the title Update SubmitUktr to use header for pillar2Id PIL-1362 Update SubmitUktr to use header for pillar2Id Dec 9, 2024
@JamesMMiller JamesMMiller marked this pull request as ready for review December 9, 2024 09:32
@platops-pr-bot
Copy link

MoDweik
MoDweik previously approved these changes Dec 9, 2024
MoDweik
MoDweik previously approved these changes Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants