Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALS-6818] Data Dictionary Loader Job from HPDS #134

Merged
merged 2 commits into from
Jan 29, 2025
Merged

[ALS-6818] Data Dictionary Loader Job from HPDS #134

merged 2 commits into from
Jan 29, 2025

Conversation

ramari16
Copy link
Contributor

No description provided.

* Add CSV loader for phenotype data

Introduced CSVLoaderNewSearch class to facilitate loading phenotype data from CSV files. Enhancements were made to the LoadingStore class, including writing column metadata to a CSV file. These changes improve data processing and metadata management functionality within the ETL workflow.

* Add CSVLoaderNewSearch jar and refine Java formatting

Added the CSVLoaderNewSearch jar to the Dockerfile and updated the Maven build process in pom.xml to include its packaging. Additionally, cleaned up Java code formatting by removing an unnecessary semicolon and adjusting spacing for consistency. These changes enhance the ETL process and maintain code readability.

* Add dumpStatsAndColumnMeta call to LoadingStore

Moved the dumpStatsAndColumnMeta execution from CSVLoaderNewSearch to LoadingStore for better encapsulation and responsibility alignment. This ensures metadata and statistics dumping is consistently handled within the store's lifecycle.
* Refactor Dockerfiles to use multi-stage builds.
Simplified builds by introducing Maven-based multi-stage builds, consolidating dependencies, and reducing image sizes. Updated entry points to ensure runtime efficiency and maintainability. Transitioned from `ADD` to `COPY` for better clarity and consistency.
@ramari16 ramari16 added the enhancement New feature or request label Jan 29, 2025
@ramari16 ramari16 merged commit d6f1ec4 into main Jan 29, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants