fix: no tittle when not set custom html title

This is why I use null coalescing.
hms5232 · Aug 15, 2024 · c17ca0f · c17ca0f
1 parent 03d61e2
commit c17ca0f
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 2 deletions.
diff --git a/resources/views/editor.blade.php b/resources/views/editor.blade.php
@@ -9,7 +9,7 @@
 
 @php
     $ver = config('swagger.editor.ver') ?? '4.5.0';
-    $title = config('swagger.editor.title', config('app.name') . ' - Swagger Editor');
+    $title = config('swagger.editor.title') ?? config('app.name') . ' - SwaggerEditor';
 @endphp
 
 <!DOCTYPE html>

diff --git a/resources/views/ui.blade.php b/resources/views/ui.blade.php
@@ -9,7 +9,7 @@
 
 @php
     $ver = config('swagger.ui.ver') ?? '4.5.0';
-    $title = config('swagger.ui.title', config('app.name') . ' - SwaggerUI');
+    $title = config('swagger.ui.title') ?? config('app.name') . ' - SwaggerUI';
 @endphp
 
 <!DOCTYPE html>

diff --git a/tests/SwaggerEditorTest.php b/tests/SwaggerEditorTest.php
@@ -158,4 +158,12 @@ public function testCustomTitle()
         $res->assertDontSee(' - Swagger Editor');
         $res->assertSee('Custom Swagger Editor');
     }
+
+    #[Test]
+    #[DefineEnvironment('swaggerCustomTitle')]
+    public function testDefaultTitle()
+    {
+        $res = $this->get('/swagger-editor');
+        $res->assertSee(' - Swagger Editor');
+    }
 }
diff --git a/tests/SwaggerUiTest.php b/tests/SwaggerUiTest.php
@@ -155,4 +155,12 @@ public function testCustomTitle()
         $res->assertDontSee(' - SwaggerUI'); // Default title
         $res->assertSee('My Swagger UI');
     }
+
+    #[Test]
+    #[DefineEnvironment('enableLS')]
+    public function testDefaultTitle()
+    {
+        $res = $this->get('/swagger');
+        $res->assertSee(' - SwaggerUI'); // Default title
+    }
 }