Skip to content
This repository has been archived by the owner on Dec 28, 2022. It is now read-only.

Fix for #160 and better serial error handling #161

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hogthrob
Copy link
Contributor

@hogthrob hogthrob commented Nov 28, 2021

We just check for the existence of the supportsLED method and only then run the code which used to work in older zigbee-herdsman versions.
In case of problems in connect we now properly stop the zigbee adapter before trying to restart it. This was a problem uncovered by #160 but not the root cause (that was the call to a no-longer-existing method of zigbee-herdsman).

We just check for the existence of the supportsLED method and only then run the code which used to work in older zigbee-herdsman versions.
In case of problems in connect we now properly stop the zigbee adapter before trying to restart it. This was a problem uncovered by hobbyquaker#160 but not the root cause (this was the call to a no-longer-existing method of zigbee-herdsman.
@jokakilla
Copy link
Contributor

I just wanted to say thanks for the fix but also ask if the root cause was really that the led control methods have been removed in zigbee-herdsman. As far as I could see these were removed with zigbee-herdsman 0.13.170.
In the dependencies part in package.json of node-red-contrib-zigbee only contains version 0.13.130. "zigbee-herdsman": "^0.13.130","

@hogthrob
Copy link
Contributor Author

hogthrob commented Dec 1, 2021

^0.13.130 means to use the newest version which is 0.13.130 or higher, but below 0.14, i.e. the newest 0.13.xxx version. You can see this by yourself here: https://semver.npmjs.com/ Just enter zigbee-herdsman and ^0.13.130

@jokakilla
Copy link
Contributor

Thanks for clarifying. I knew semver with major, minor, patch versions but missed the meaning of the prefix in context of node.

@vibornoff
Copy link

JFYI this PR works fine.
@hobbyquaker merge it please.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants