Ensure Bare.exit() can be called in idle

holepunchto · Jun 21, 2024 · bed9ca3 · bed9ca3
1 parent d19cc73
commit bed9ca3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/src/runtime.c b/src/runtime.c
@@ -1168,7 +1168,9 @@ bare_runtime_run (bare_runtime_t *runtime) {
 
       if (uv_loop_alive(runtime->loop)) continue;
 
-      uv_ref((uv_handle_t *) &runtime->signals.resume);
+      if (!runtime->terminated) {
+        uv_ref((uv_handle_t *) &runtime->signals.resume);
+      }
     } else {
       bare_runtime_on_before_exit(runtime);
     }

diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
@@ -3,6 +3,7 @@ list(APPEND tests
   addon-resolve.js
   argv-empty.c
   exit-on-before-exit.js
+  exit-on-idle.js
   import-addon.cjs
   import-addon.mjs
   import-bundle.js

diff --git a/test/exit-on-idle.js b/test/exit-on-idle.js
@@ -0,0 +1,6 @@
+/* global Bare */
+Bare
+  .on('idle', () => {
+    Bare.exit()
+  })
+  .suspend()