Batch extends from ReadyResource #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuKks
commented
Jun 19, 2023
| return this._appendBatch(batch) | ||
| await this._appendBatch(batch) | ||
|
|
||
| return this.close() |
There was a problem hiding this comment.
This also fixes a potential bug that Hans pointed out, it closes this:
Line 843 in b527eea
There was a problem hiding this comment.
Its never a snap when appending
|
Prop a good idea! I'll leave this open, cause I wanna use this oppurtunity to clean up the clean up of the session which is all over the place atm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good for Batch to match same API properties as Hyperbee. More importantly, it allows to precisely check if resources (batch, etc) are actually closed in Hyperdrive tests