Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byte stream should force binary encoding when 'valueEncoding' is set … #458

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Byte stream should force binary encoding when 'valueEncoding' is set … #458

merged 4 commits into from
Nov 13, 2023

Conversation

zacharygriffee
Copy link
Contributor

@zacharygriffee zacharygriffee commented Nov 12, 2023

Added a test as well.

fixes #457 (comment)

@mafintosh
Copy link
Contributor

Some lint errors. Tried to fix some bug are on my phone

@zacharygriffee
Copy link
Contributor Author

Some lint errors. Tried to fix some bug are on my phone

Ooo. Sorry. I forgot to run the standard fixers. Working on it now.

@mafintosh mafintosh merged commit 4096ec0 into holepunchto:main Nov 13, 2023
4 checks passed
@mafintosh
Copy link
Contributor

Thanks!

@mafintosh
Copy link
Contributor

Going out in next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createByteStream with range option tries to parse the range post 'valueEncoded' values.
2 participants