Add blocks/bytes uploaded/downloaded stats #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HDegroote
commented
Sep 3, 2024
| @@ -2004,6 +2017,10 @@ module.exports = class Replicator { | |||
|
|
|||
| _ondata (peer, req, data) { | |||
| if (data.block !== null) { | |||
| this.stats.blocksDownloaded++ | |||
There was a problem hiding this comment.
Please double check that this code runs if-and-only-if a block was downloaded. I think this is the correct shared path, but not 100% sure
HDegroote
commented
Sep 3, 2024
| @@ -2004,6 +2017,10 @@ module.exports = class Replicator { | |||
|
|
|||
| _ondata (peer, req, data) { | |||
| if (data.block !== null) { | |||
| this.stats.blocksDownloaded++ | |||
| this.stats.bytesDownloaded += data.block.value.byteLength | |||
There was a problem hiding this comment.
Note: this will crash if a block ever does not contain a Buffer block.value entry. The code assumes this never happens (which I think is true, but good to confirm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you prefer, we can also use
Instead of
But I found that looked a bit strange (particularly for
bytes)