Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hotswaps #597

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Add hotswaps #597

merged 6 commits into from
Nov 18, 2024

Conversation

mafintosh
Copy link
Contributor

No description provided.

@mafintosh mafintosh marked this pull request as ready for review November 18, 2024 18:42
lib/replicator.js Outdated Show resolved Hide resolved
@HDegroote
Copy link
Contributor

Sanity check (quicker than fully tracing it myself):

hypercore/lib/replicator.js

Lines 1973 to 1977 in 69d15e9

_clearRequest (peer, req) {
if (req.block !== null) {
this._clearInflightBlock(this._blocks, req)
this._unmarkInflight(req.block.index)
}

=> Do we not need to remove the hotswap here, and/or handle the case where this is the answer to a hotswap request?

@mafintosh
Copy link
Contributor Author

Checking

@mafintosh
Copy link
Contributor Author

We do, nice one

@mafintosh
Copy link
Contributor Author

@HDegroote pushed a tweak for your thing above

@mafintosh mafintosh merged commit b771d91 into main Nov 18, 2024
4 checks passed
@mafintosh mafintosh deleted the hotswaps branch November 18, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants