rocksdb: SessionState.moveTo API #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafintosh
reviewed
Dec 3, 2024
index.js
Outdated
| @@ -326,6 +328,7 @@ class Hypercore extends EventEmitter { | |||
| } | |||
|
|
|||
| this.state.addSession(this) | |||
| this._sessionOpen = true | |||
There was a problem hiding this comment.
instead of using this flag you can just check that stateIndex !== -1
mafintosh
reviewed
Dec 3, 2024
index.js
Outdated
| @@ -299,7 +301,7 @@ class Hypercore extends EventEmitter { | |||
| } | |||
|
|
|||
| if (opts.parent) { | |||
| if (opts.parent.state === null) await opts.parent.ready() | |||
| if (!opts.parent._sessionOpen) await opts.parent.ready() | |||
There was a problem hiding this comment.
see comment below but opts.parent._stateIndex === -1 should do the trick
mafintosh
force-pushed
the
rocksdb-move-to
branch
from
99fcba6 to
3956f33
Compare
* inherit more from parent * simplify
* drafts are writable * session overwrite should emit events
mafintosh
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.