Fix crash in mtu_probeify_packet() #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…makes the assert in mtu_probeify more strict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable MTU probing if the OS-Discovered pMTU (returned from
getsockopt(socket, IP_MTU, )is less than UDX_MTU_BASE (1200 bytes). This is a temporary fix to prevent the assert in mtu_probeify_packet() from triggering a crash when generating a probe to these hosts. It doesn't actually lower libudx's initial MTU below 1200, so if this OS-Discovered pMTU is correct these hosts will typically time out.