(breaking) Sync lifecycle #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to use the more common sync initialisation pattern, where it is initialised in the constructor, and torn down in a sync destroy method |
mafintosh
reviewed
Jan 26, 2025
index.js
Outdated
| [...this.store.cores.map.values()].map(this._oncoreopenBound) | ||
| ) | ||
| // Give time to add event handlers | ||
| setImmediate(() => { |
There was a problem hiding this comment.
why is the immediate needed?
There was a problem hiding this comment.
Should have been queueMicroTask + needed a check on whether it was already destroyed. Pushed a fix.
The reason is to give time to add event-handlers before the background processing starts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial approach was extracted from blind-peer, where ready/close lifecycle was async. But I've realised that the lifecycle is actually sync: the invariant of passive-core-watcher is that it calls the
openfunction for all cores that are open (for those wherewatchreturns true)The async lifecycle added the unneeded invariant that
openis called for all already-opened cores BEFORE ready resolves. Now it just guarantees thatopenwill be called at some point, which is what we want anyway.Note: the change is backwards compatible (verified with blind-peer)