Add mac address to Interfaces #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the mac address to the interface struct inside the `holo-interface` module. We also modify the necessary ibus and netlink functions to fit the updated field. Signed-off-by: Paul Wekesa <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #29 +/- ##
==========================================
- Coverage 63.07% 63.07% -0.01%
==========================================
Files 179 179
Lines 30018 30019 +1
==========================================
Hits 18933 18933
- Misses 11085 11086 +1 ☔ View full report in Codecov by Sentry. |
rwestphal
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce the Mac Address to the Interface struct inside the
holo-interfacemodule.The netlink message Nla giving us this information has been modified to catter for this, we also modify the respective Ibus functions to make sure the mac address is put in while updating the interface details.