p2p-shipyard integration & fixes for android #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mobile & desktop viewports
…id poor UX until we have them working
mattyg
changed the title
|
okay @zippy this is ready for review & merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this introduces a bug where attempting to run two instances of the desktop app via p2p-shipyard results in the 2nd instance panicking immediately. I think it makes sense to merge as-is (we can still run 2 desktop instances via hc-spin) and I'll create an issue to track.
This still uses stock holochain & p2p-shipyard, not including the upcoming changes required for android support (holochain/holochain#4101 and darksoil-studio/p2p-shipyard#14 )