-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App structure: DNAs page #516
base: main
Are you sure you want to change the base?
Conversation
…ucture-zome-functions
…e/app-structure-dnas
005aa7c
to
994c997
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really long PR that includes much more than the issue is about. I suppose this is based off of another branch that addresses the other issues, so I haven't reviewed callbacks and zomes. I did review the DNA part and glossed over the relaxed ordering parts for entries. I haven't run the code examples.
The DNA part looks good to me with a few change requests.
src/pages/build/dnas.md
Outdated
* `name`: A string for humans to read. This might get used in the admin panel of Holochain [conductors](/concepts/2_application_architecture/#conductor) like [Holochain Launcher](https://github.com/holochain/launcher) or [Moss](https://theweave.social/moss/). | ||
* `integrity`: Contains all the integrity modifiers for the DNA, the things that **change the DNA hash**. | ||
* `network_seed`: A string that serves only to change the DNA hash without affecting behavior. It acts like a network-wide passcode. {#network-seed} | ||
* `properties`: Arbitrary, application-specific constants. The integrity code can access this, deserialize it, and change its runtime behavior. Think of it as configuration for the DNA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* `properties`: Arbitrary, application-specific constants. The integrity code can access this, deserialize it, and change its runtime behavior. Think of it as configuration for the DNA. | |
* `properties`: Arbitrary, application-specific constants. The zome code can read this at runtime. Think of it as configuration for the DNA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dna_info
is in the hdi
crate, so it's accessible to the validate
and genesis_self_check
functions. This lets you implement patterns like Progenitor. (But I hear you about coordinators being able to access it too; I'll add that.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay, so just "the zome code".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still says "the integrity code".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so weird; not the first time my edits have just vanished. Thanks for the heads-up.
Co-authored-by: Jost <[email protected]>
…docs-pages into feat/guide/app-structure-dnas
src/pages/build/dnas.md
Outdated
* `name`: A string for humans to read. This might get used in the admin panel of Holochain [conductors](/concepts/2_application_architecture/#conductor) like [Holochain Launcher](https://github.com/holochain/launcher) or [Moss](https://theweave.social/moss/). | ||
* `integrity`: Contains all the integrity modifiers for the DNA, the things that **change the DNA hash**. | ||
* `network_seed`: A string that serves only to change the DNA hash without affecting behavior. It acts like a network-wide passcode. {#network-seed} | ||
* `properties`: Arbitrary, application-specific constants. The integrity code can access this, deserialize it, and change its runtime behavior. Think of it as configuration for the DNA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still says "the integrity code".
use movies_integrity::{EntryTypes, LinkTypes, Movie, Director}; | ||
``` | ||
|
||
!!! info Why do I need to specify the dependency twice? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, if that's a bug then fine.
this was supposed to already happen; got lost somehow Co-authored-by: Jost <[email protected]>
All about DNAs. Closes #488. Depends on #512. Don't review until those are merged, cuz otherwise this PR will seem bigger than it really is.