e2e-crypto #1
Merged
e2e-crypto #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ThetaSinner <[email protected]>
ThetaSinner
approved these changes
Apr 29, 2024
|
|
||
| // Mutex strategy in this file is built on the assumption that this will | ||
| // largely be network bound. Since we only have the one rate-limited connection | ||
| // to the sbd server, it is okay to wrap it with a tokio Mutex and do the |
There was a problem hiding this comment.
I do use a std mutex in the sodoken_crypto module, but in this case I'm talking about the tokio mutexes around the inner and receiver because they need to be held across awaits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPENDS ON: #2
RESOLVES: #19
Adds a libsodium secretstream-based p2p-e2e encryption wrapper for the sbd client.