Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address file presence in choose_or_get_template options #184

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

c12i
Copy link
Collaborator

@c12i c12i commented Jan 18, 2024

This PR fixes #182

@c12i c12i requested a review from guillemcordoba January 18, 2024 23:15
@c12i c12i changed the title fix: file in choose_or_get_template options fix: address file presence in choose_or_get_template options Jan 18, 2024
@c12i c12i requested a review from ThetaSinner January 18, 2024 23:20
@c12i c12i added ShouldBackport/0.1 This change should be backported to develop-0.1 ShouldBackport/0.2 This change should be backported to develop-0.2 labels Jan 19, 2024
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@c12i c12i merged commit 508f3a1 into holochain:develop Jan 19, 2024
2 checks passed
@c12i c12i removed the ShouldBackport/0.2 This change should be backported to develop-0.2 label Feb 8, 2024
c12i added a commit to c12i/scaffolding that referenced this pull request Feb 8, 2024
…options

fix: address file presence in choose_or_get_template options
@c12i c12i removed the ShouldBackport/0.1 This change should be backported to develop-0.1 label Feb 8, 2024
c12i added a commit to c12i/scaffolding that referenced this pull request Feb 8, 2024
…options

fix: address file presence in choose_or_get_template options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choose UI framework options can contain files present in a .templates directory
2 participants