Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lit template ts error #448

Merged
merged 2 commits into from
Feb 4, 2025
Merged

fix: lit template ts error #448

merged 2 commits into from
Feb 4, 2025

Conversation

c12i
Copy link
Collaborator

@c12i c12i commented Jan 16, 2025 •
edited
Loading

This PR fixes a ts error that was preventing vite build from running for lit templates

https://github.com/holochain/scaffolding/actions/runs/12763486851/job/35573852491#step:6:1006

@c12i c12i changed the title Fix lit template ts error fix: lit template ts error Jan 16, 2025
@c12i c12i added the ShouldBackport/0.4 This change should be backported to develop-0.1 label Jan 16, 2025
@c12i c12i requested a review from a team January 17, 2025 08:00
ThetaSinner
ThetaSinner requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build isn't passing

@c12i
Copy link
Collaborator Author

c12i commented Jan 17, 2025

Build is failing because of tryorama issue with running hc s create, fix in in place at holochain/holochain#4630

@c12i c12i mentioned this pull request Jan 17, 2025
Merged
7 tasks
@c12i c12i added should_backport Requires backporting and removed ShouldBackport/0.4 This change should be backported to develop-0.1 labels Jan 20, 2025
@c12i c12i changed the base branch from develop to develop-0.4 January 20, 2025 17:39
@c12i c12i changed the base branch from develop-0.4 to develop January 20, 2025 17:39
@c12i c12i removed the should_backport Requires backporting label Jan 20, 2025
@c12i c12i mentioned this pull request Jan 28, 2025
Merged
@c12i c12i requested review from ThetaSinner and a team February 3, 2025 07:42
@ThetaSinner
Copy link
Member

Does this one need backporting?

@c12i
Copy link
Collaborator Author

c12i commented Feb 4, 2025 •
edited
Loading

Already "backported" via a separate PR (#450), main-0.4 wasn't experiencing the issue with hc s create that had been blocking this PR

@c12i c12i merged commit 1874fea into main Feb 4, 2025
12 checks passed
@c12i c12i deleted the fix/lit-template-ts-error branch February 4, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jost-s jost-s jost-s approved these changes

@ThetaSinner ThetaSinner ThetaSinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c12i @ThetaSinner @jost-s