Update Cue tutorial to use testscript #410
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying holos with
|
| Latest commit: |
ae4aad4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://69fdef92.holos.pages.dev |
| Branch Preview URL: | https://gl-embed-timoni-for-tests.holos.pages.dev |
glarizza
force-pushed
the
gl/embed-timoni-for-tests
branch
from
b76e825 to
93ced64
Compare
glarizza
commented
Jan 23, 2025
| @@ -1,3 +1,7 @@ | |||
| #! /bin/bash | |||
| set -xeuo pipefail | |||
|
|
|||
| # Necessary to install timoni for testscript execution | |||
| make go-deps | |||
There was a problem hiding this comment.
Note that we're running make go-deps now during the test script. Total execution time of installing deps and running the tests is about 3 minutes.
PROBLEM: The "Cue" tutorial has hardcoded code blocks and hasn't been updated to use the automated testscript workflow. NOTE: This is slightly more complex than normal because we need to make sure Timoni is installed when we execute the testscripts due to the fact that we need to execute `timoni mod vendor crds ...` and capture the output. SOLUTION: * Add Timoni as one of the packages that are installed via `make go-deps`. * Update the testing GH Action to install all go dependencies before executing the tests. * Create a test for the Cue tutorial. * Create a testscript for the Cue test. * Update the Cue MDX file to load in data from the testscript directory. OUTCOME: The code content in the Cue tutorial now comes directly from the testscript workflow.
glarizza
force-pushed
the
gl/embed-timoni-for-tests
branch
from
93ced64 to
ae4aad4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROBLEM:
The "Cue" tutorial has hardcoded code blocks and hasn't been
updated to use the automated testscript workflow.
NOTE: This is slightly more complex than normal because we need
to make sure Timoni is installed when we execute the testscripts
due to the fact that we need to execute
timoni mod vendor crds ...and capture the output.
SOLUTION:
make go-deps.OUTCOME:
The code content in the Cue tutorial now comes directly from the
testscript workflow.