Skip to content

Commit

Permalink
Unpin nbconvert (#155)
Browse files Browse the repository at this point in the history
Can no longer reproduce the error in #84.
  • Loading branch information
ceball authored Dec 18, 2019
1 parent 451bde0 commit 9fd5088
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,22 @@ def get_setup_version(root, reponame):
'jupyter_client',
'ipykernel',
'nbformat',
'nbconvert <5.4', # see https://github.com/pyviz/nbsite/issues/84
'nbconvert',
'notebook',
'sphinx',
'beautifulsoup4',
# Without the tornado pin below, I get:
# File "[...]/code/[...]/nbsite/nbsite/nbbuild.py", line 35, in <module>
# from nbconvert import NotebookExporter, PythonExporter, HTMLExporter
# File "[...]/[...]/lib/python3.7/site-packages/nbconvert/__init__.py", line 7, in <module>
# from . import postprocessors
# File "[...]/[...]/lib/python3.7/site-packages/nbconvert/postprocessors/__init__.py", line 5, in <module>
# from .serve import ServePostProcessor
# File "[...]/[...]/lib/python3.7/site-packages/nbconvert/postprocessors/serve.py", line 19, in <module>
# class ProxyHandler(web.RequestHandler):
# File "[...]/[...]/lib/python3.7/site-packages/nbconvert/postprocessors/serve.py", line 21, in ProxyHandler
# @web.asynchronous
#AttributeError: module 'tornado.web' has no attribute 'asynchronous'
'tornado <6'
],
extras_require= {
Expand Down

0 comments on commit 9fd5088

Please sign in to comment.