Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: Numba 0.61 and Python 3.13 #1373

Closed
wants to merge 8 commits into from
Closed

compat: Numba 0.61 and Python 3.13 #1373

wants to merge 8 commits into from

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Dec 2, 2024

Windows does not solve because of libxml2 pin and Python 3.13 because of zlib pin.

numba/llvmlite#1105

test-gpu:

image

@hoxbro hoxbro marked this pull request as draft December 2, 2024 10:40
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.36%. Comparing base (f23de59) to head (f447818).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1373      +/-   ##
==========================================
- Coverage   88.53%   86.36%   -2.17%     
==========================================
  Files          93       93              
  Lines       18744    18744              
==========================================
- Hits        16595    16189     -406     
- Misses       2149     2555     +406     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amaloney amaloney added this to the v0.17.0 milestone Jan 21, 2025
@amaloney
Copy link
Collaborator

I must be doing something wrong as I am unable to solve an environment using pixi. I'm running pixi shell in order to create the default environment, but instead of creating a default one, it attempts to create all environments in the environments table and will not solve anything unless I add the platform to the features.test-gpu table.

@hoxbro
Copy link
Member Author

hoxbro commented Jan 22, 2025

I'm running pixi shell in order to create the default environment

This PR is still in draft; I just wanted to see if PyPi would solve it, which it wouldn't. What you are seeing is the solving of environments with PyPi dependencies, where it needs to download the PyPI package to solve. I have removed this and will wait on the conda-forge release.

@hoxbro hoxbro changed the title compat: Numba 0.61 compat: Numba 0.61 and Python 3.13 Jan 28, 2025
@hoxbro
Copy link
Member Author

hoxbro commented Jan 28, 2025

I don't think we can wait anymore for the release of numba and llvmlite on conda-forge for releasing datashader 0.17.0. Currently, it needs conda-forge/llvmlite-feedstock#96 to be merged, followed by conda-forge/numba-feedstock#150.

Most changes to pixi.toml can be reverted when numba is released on conda-forge. See NOTE: comments.

@amaloney: I see two options for this PR: merge the PR as is or do a new PR with the updates to README.md and pyproject.toml classifiers. I'm leaning toward the latter.

@hoxbro hoxbro removed this from the v0.17.0 milestone Jan 28, 2025
@hoxbro
Copy link
Member Author

hoxbro commented Jan 30, 2025

superseded by #1403

@hoxbro hoxbro closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants